AdamCaviness/vs-code-theme-monokai-dark-soda

Non-workbench editor does not show highlighting

atkinchris opened this issue · 2 comments

The highlight colour in Monokai Dark Soda is the same colour as the background of non-workbench panels, so highlights cannot be seen. This appears to have happened when VS Code switched to using the Monaco editor for settings search, source control and more.

Default theme:
Screenshot 2020-03-02 at 14 48 09

Monokai Dark Soda:
Screenshot 2020-03-02 at 14 47 56

For reference, this is the highlighting colour when used in a workbench window:
Screenshot 2020-03-02 at 14 51 35

I think, either:

  1. Fix foreground and highlight colours in non-workbench text editors
  2. Don't apply colour theme to non-workbench text editors (this might be a VS Code change)

Work around

Add the below lines to your settings.json. It changes the input box background colour to the same as the workbench background, so highlights are visible.

    "workbench.colorCustomizations": {
        "[Monokai Dark Soda]": {
            "input.background": "#242424"
        }
    }

Screenshot 2020-03-02 at 15 12 05

there is already a PR this fix #7

Merged PR , thanks.