AdamXweb/WhiteSurFirefoxThemeMacOS

Firefox 117 broke most features of this theme.

StickPal opened this issue · 8 comments

Describe the problem

as the title suggests, this new version broke most things such as the close, minimize, and restore buttons, it also broke some fonts (i think??) and other things. this could be caused by something changed about sizes of images, but I haven't looked into it for now, that's in relation with the title bar icons ( as mentioned before ). I've also seen some similar issues with other themes, aparently If you were using appearance: -moz-win-borderless-glass somewhere in your code, it's broken now and it has to be commented out or removed.

Version

1.5.2

OS

Windows 11

Firefox Version

117

Install Options

none

Colour Theme

auto

Additional info

Screenshot 2023-08-31 145549

Please tick the boxes

did you find any solution yet? @StickPal

did you find any solution yet? @StickPal

unfortunately no, I suppose your best solution at this moment would be to just downgrade to an earlier version like 115 etc, until Adam finds a better solution later on.

Hi @StickPal thanks for submitting the issue. This is a duplicate of #99 and #98, but there are a few good pickups like the spacing of buttons, font weight on tabs and a few other oddities with the tabsbar that have broken.
It looks like the bugs are limited to Windows, and i'll work on it as soon as I have access to a Windows VM again to test. In the meantime a pending pull request should fix the main issue of the window buttons.

Can you confirm if you've made any alterations for the tabs bar to be above the URL bar?

Hi @StickPal thanks for submitting the issue. This is a duplicate of #99 and #98, but there are a few good pickups like the spacing of buttons, font weight on tabs and a few other oddities with the tabsbar that have broken. It looks like the bugs are limited to Windows, and i'll work on it as soon as I have access to a Windows VM again to test. In the meantime a pending pull request should fix the main issue of the window buttons.

Can you confirm if you've made any alterations for the tabs bar to be above the URL bar?

Hey @AdamXweb thanks for coming back this quickly! I can confirm that I have not changed anything in the files to make the tabs bar go above the URL bar. I actually didn't notice it until this message. I must've paid more attention to the buttons, etc.

I've released v1.5.3, please test to ensure it works on your machine.
Can confirm is working on Windows 11 v117
Screenshot 2023-09-05 at 3 43 31 pm

I've released v1.5.3, please test to ensure it works on your machine. Can confirm is working on Windows 11 v117 Screenshot 2023-09-05 at 3 43 31 pm

I can confirm that the issue has been fixed, and it's now working perfectly. Thank you so much!
image

All though, I can now see a tiny issue with how the window border is set up, this could easily be a windows thing and nothing to do with the theme but I'am seeing a tiny change in how the icons are positioned, but honestly, the problem isn't that big and really it shouldn't be changed, But thanks alot!
image

Thanks @AdamXweb @StickPal for solving this issue.