AdamXweb/WhiteSurFirefoxThemeMacOS

[BUG] Install flags not working for release v1.5 for M1 Macs

Closed this issue · 6 comments

Describe the problem

Hi, install flags are not registering during install for M1 Macs. I tried the basic "bash install.sh -c" on multiple devices, and the close button was on the right. I also experimented with multiple flags, such as "-c -u", which still did nothing.

Version

1.5

OS

macOS 13.1

Firefox Version

109

Install Options

-c, -c -u, -c -f

Colour Theme

n/a

Additional info

No response

Please tick the boxes

Thanks for submitting this issue!
Could you please test this latest release which is based on the most recent commit:
https://github.com/AdamXweb/WhiteSurFirefoxThemeMacOS/releases/tag/v1.5.1

v1.5.1 did not work, I tested both a simple bash install.sh -c as well as the Safari-like bash ./install.sh -c -n -s -e

Before jumping into specifics diagnosing this issue, could you please confirm if the script created the custom folder in the Firefox profile. You can access it by typing about:support into the URLbar and clicking
Screen Shot 2023-01-31 at 3 10 09 pm
Testing to see if it has a folder named custom inside the WhiteSur folder.
Screen Shot 2023-01-31 at 3 09 32 pm
If not, then you could try the latest commit? This forces the folder to be stored in Git to avoid this issue.

The custom folder is not being created, here is an example of an error that shows in Terminal when running bash install.sh

**[action]: ⇒ Installing WhiteSur Firefox theme to your directory below
/Users/*USER/Library/Application Support/Firefox/Profiles/*default-release /Users/*USER/Library/Application Support/Firefox/Profiles/sisln89p.default-release
Enabling Tab close button on Left hand side
cp: /Users/USER/Library/Application Support/Firefox/Profiles/default-release/chrome/WhiteSur/custom: No such file or directory

This was tried with the latest commit, v1.5.1.

I believe that you are targeting the correct folder (Application Basics>Profile Folder) for initial transfer of the new theme, which is located at ".../Profiles/sisln89p.default-release", but then trying to install the modified css flags at location ".../Profiles/*default-release", without the "sisln89p." before it.

Can you try placing a folder called custom inside the git repository inside the WhiteSur folder?

hi, downloading the latest commit works! installed correctly, I would make that the next release