AdaptiveParticles/pyapr

Failed compilation on linux

Closed this issue · 1 comments

From master (recently merged)

Running:

mkdir build
cd build
cmake ..
make

Hav ethe following openmp compilation errors:

This could be to do with my version of compiler, its a recent install of latest ubuntu. But its a compilation error it seems from LibAPR. (OpenMP 4.5)

/home/bevan/Play/PyLibAPR/LibAPR/src/numerics/APRReconstruction.hpp:605:61: error: ‘step_size’ not specified in enclosing ‘parallel’
605 | const int dim1 = apr_iterator.y() * step_size;
| ^~~~~~~~~
/home/bevan/Play/PyLibAPR/LibAPR/src/numerics/APRReconstruction.hpp:599:9: error: enclosing ‘parallel’
599 | #pragma omp parallel for schedule(dynamic) default(none) shared(level_val, level, img) private(z, x) firstprivate(apr_iterator) collapse(2)
| ^~~
/home/bevan/Play/PyLibAPR/LibAPR/src/numerics/APRReconstruction.hpp:630:43: error: ‘max_level’ not specified in enclosing ‘parallel’
630 | for (z = 0; z < apr_iterator.z_num(max_level); z++) {
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/home/bevan/Play/PyLibAPR/LibAPR/src/numerics/APRReconstruction.hpp:628:9: error: enclosing ‘parallel’
628 | #pragma omp parallel for schedule(dynamic) default(none) shared(level_val, img) private(z, x) firstprivate(apr_iterator) collapse(2)
| ^~~
/home/bevan/Play/PyLibAPR/LibAPR/src/numerics/APRReconstruction.hpp: In static member function ‘static void APRReconstruction::interp_img(APR&, PixelData&, ParticleDataType&) [with U = short unsigned int; ParticleDataType = ParticleData]’:
/home/bevan/Play/PyLibAPR/LibAPR/src/numerics/APRReconstruction.hpp:96:61: error: ‘step_size’ not specified in enclosing ‘parallel’
96 | const int dim1 = apr_iterator.y() * step_size;
| ^~~~~~~~~
In file included from /home/bevan/Play/PyLibAPR/pyapr/numerics/reconstruction/PyAPRReconstruction.hpp:4,
from /home/bevan/Play/PyLibAPR/wrappers/pythonBind.cpp:18:
/home/bevan/Play/PyLibAPR/LibAPR/src/numerics/APRReconstruction.hpp:88:9: error: enclosing ‘parallel’
88 | #pragma omp parallel for schedule(dynamic) default(none) shared(img, level, parts) private(z, x, temp_int) firstprivate(apr_iterator) collapse(2)
| ^~~

Just checked yeah its failing on just normal LibAPR on develop_joel on mine as well... however develop is passing. Sec let me have a quick looka t the errors then direclty on the branch. Is this something you have recently touched?