AdguardTeam/PopupBlocker

`Manage preferences` option is broken

Closed this issue · 8 comments

kodiakhub commented

After clicking Manage preferences... the redirected address popupblocker.adguard.com/options.html is not working properly.

Screenshot

SS

  • Tampermonkey v4.18.1
stanislav-atr commented

@kodiakhub , hi! Thank you for feedback, this will be fixed in the closes release.

  • 👍1
kodiakhub commented

Hi @stanislav-atr, the Manage preferences... option still doesn't work.

However, the site address https://popupblocker.adguard.com/release/v1/options.html can be accessed manually.

  • Google Chrome v114.0.5735.91
  • Tampermonkey v4.19.0
    • AdGuard Popup Blocker v2.5.87
Video detail

Footnote for the video: I blocked the site's cookie for continuity testing.

P.mp4

stanislav-atr commented

@kodiakhub, hi! I was not able to reproduce this on my device. Is this incognito-only issue? Are there any errors in devtool's console going when trying to open settings?

kodiakhub commented

Is this incognito-only issue?

No, both have the issue.

Are there any errors in devtool's console going when trying to open settings?

Guess, no.

Video

Nope.mp4

If you need more information, do you have a test example site for the AdGuard Popup Blocker?

stanislav-atr commented
  1. Go to http://example.org/
  2. Run document.documentElement.addEventListener("click", () => window.open(/test) ); in console
  3. Click anywhere on the page to trigger popup
  4. Try opening settings

also, do you use some other userscripts/extensions that could interfere?

kodiakhub commented
  1. Go to http://example.org/
  2. Run document.documentElement.addEventListener("click", () => window.open(/test) ); in console
  3. Click anywhere on the page to trigger popup
  4. Try opening settings
  1. Tampermonkey is blacklisted for example.org in its default security settings:
Screenshot

image

  1. Entering the command in the console tab gave an error:
Screenshot

image

I don't have knowledge on this. It could be user error.

But i tested on another test website from https://github.com/AdguardTeam/PopupBlocker#how-to-test:

This one is working but not on this website like i found: izleorg3.org

Video

Test.mp4

also, do you use some other userscripts/extensions that could interfere?

No.

@stanislav-atr If you still can't reproduce, no problem. I found such a strange issue and reported it. There is no need to dwell on this issue, because it is not so important. 👍

stanislav-atr commented 
Entering the command in the console tab gave an error:

formatting broke the code, my bad:
document.documentElement.addEventListener("click", () => window.open("/test") );

It seems that izleorg3.org#%#//scriptlet("prevent-window-open") rule is being applied on the page, successfuly blocking settings. If you prefer using popupblocker, you may disable this rule with izleorg3.org#@%#//scriptlet("prevent-window-open".

  • 👍1
kodiakhub commented

You are right! Adding this rule izleorg3.org#@%#//scriptlet("prevent-window-open") in the user rules fixes the issue. But still didn't expect that AdGuard Adblock filter lists would block the AdGuard Popup Blocker itself. 😄

  • 🚀1