AdoptOpenJDK/openjdk-api

API needs to differentiate between Regular OpenJ9 and the Large Heap variant

dinogun opened this issue · 2 comments

dinogun commented

OpenJ9 appears to have two variants, Regular and Large Heap. Calling the info API results in both of them being retrieved

{
  "release_name": "jdk10u-2018-07-30-18-04",
  "timestamp": "2018-07-30T18:04:57Z",
  "binaries": [
    {
      "os": "linux",
      "architecture": "x64",
      "binary_type": "jdk",
      "openjdk_impl": "openj9",
      "binary_name": "OpenJDK10U_x64_linux_openj9_2018-07-30-15-14.tar.gz",
      "binary_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_2018-07-30-15-14.tar.gz",
      "binary_size": 209664403,
      "checksum_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_2018-07-30-15-14.tar.gz.sha256.txt",
      "version": "10"
    },
    {
      "os": "linux",
      "architecture": "x64",
      "binary_type": "jdk",
      "openjdk_impl": "openj9",
      "binary_name": "OpenJDK10U_x64_linux_openj9_linuxXL_2018-07-30-15-24.tar.gz",
      "binary_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_linuxXL_2018-07-30-15-24.tar.gz",
      "binary_size": 209638302,
      "checksum_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_linuxXL_2018-07-30-15-24.tar.gz.sha256.txt",
      "version": "10"
    }
  ]
}

Correspondingly querying for the binary results in the following response

Multiple binaries match request: [ { "os": "linux", "architecture": "x64", "binary_type": "jdk", "openjdk_impl": "openj9", "binary_name": "OpenJDK10U_x64_linux_openj9_2018-07-30-15-14.tar.gz", "binary_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_2018-07-30-15-14.tar.gz", "binary_size": 209664403, "checksum_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_2018-07-30-15-14.tar.gz.sha256.txt", "version": "10" }, { "os": "linux", "architecture": "x64", "binary_type": "jdk", "openjdk_impl": "openj9", "binary_name": "OpenJDK10U_x64_linux_openj9_linuxXL_2018-07-30-15-24.tar.gz", "binary_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_linuxXL_2018-07-30-15-24.tar.gz", "binary_size": 209638302, "checksum_link": "https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk10u-2018-07-30-18-04/OpenJDK10U_x64_linux_openj9_linuxXL_2018-07-30-15-24.tar.gz.sha256.txt", "version": "10" } ]

Maybe we need another variable like &openjdk_impl_variant=large_heap to return the Large Heap and if nothing is specified, only the regular variant is returned.

dinogun commented

Hit the same issue again today with this query

{
  "release_name": "jdk9u-2018-08-20-13-45",
  "timestamp": "2018-08-20T13:45:16Z",
  "release": false,
  "binaries": [
    {
      "os": "linux",
      "architecture": "x64",
      "binary_type": "jdk",
      "openjdk_impl": "openj9",
      "binary_name": "OpenJDK9U_x64_linux_openj9_2018-08-20-13-45.tar.gz",
      "binary_link": "https://github.com/AdoptOpenJDK/openjdk9-binaries/releases/download/jdk9u-2018-08-20-13-45/OpenJDK9U_x64_linux_openj9_2018-08-20-13-45.tar.gz",
      "binary_size": 211112158,
      "checksum_link": "https://github.com/AdoptOpenJDK/openjdk9-binaries/releases/download/jdk9u-2018-08-20-13-45/OpenJDK9U_x64_linux_openj9_2018-08-20-13-45.tar.gz.sha256.txt",
      "version": "9"
    },
    {
      "os": "linux",
      "architecture": "x64",
      "binary_type": "jdk",
      "openjdk_impl": "openj9",
      "binary_name": "OpenJDK9U_x64_linux_openj9_linuxXL_2018-08-20-13-45.tar.gz",
      "binary_link": "https://github.com/AdoptOpenJDK/openjdk9-binaries/releases/download/jdk9u-2018-08-20-13-45/OpenJDK9U_x64_linux_openj9_linuxXL_2018-08-20-13-45.tar.gz",
      "binary_size": 211090945,
      "checksum_link": "https://github.com/AdoptOpenJDK/openjdk9-binaries/releases/download/jdk9u-2018-08-20-13-45/OpenJDK9U_x64_linux_openj9_linuxXL_2018-08-20-13-45.tar.gz.sha256.txt",
      "version": "9"
    }
  ]
}
johnoliver commented

hopefully you can fix this now by adding heap_size=normal (or large if you want a xl build) to your api query

  • 👍1