Adornis/typescript

Typescript version selection

Closed this issue · 6 comments

I'm wondering how exactly is the typescript version selection done?

We're experiencing some weird issues with our build, where it seems that the compilation is happening with an older TS-version than what we have in our node_modules. More specifically the compiler is logging cant compile because of syntax errors when it encounters generics in JSX, which have been supported since 2.9 (our version is 3.3.1).

Any pointers on how to debug the issue would be appreciated, since I have zero knowledge in Meteor packages.

yorrd commented

@kirstu, let me get back to you next week. I was fairly certain that were on 3.3.x, being the latest at the time. Maybe I accidentally reversed the change. Feel free to clone the repo into your /packages directory and try changing the line. Let me know if it helps

Yes, I was able to upgrade the version to 3.3.1 by creating a local package override and bumping the version in typescript-compiler's package.js.

yorrd commented

@kirstu, feel like pushing that to your repo and starting a pull request? I can accept it today.

yorrd commented

accepted and done! Thanks :)