[FORGE] Old Lighting Rendering displays light levels 4 to 1 as light level 0.

[Thombias]

Version Information

Please fill out the following information. Replace each x with a number:

Minecraft Version: 1.18.2
Forge Version: 40.1.80
Nostalgic Tweaks Version: 1.0.7

Describe the Bug

A clear and concise description of what the bug is (e.g., startup crash, runtime crash, or something not working as intended).

The title describes pretty much the whole thing. I've noticed that the lighting coming from a block source of light ends very harshly. I then disabled the old lighting rendering to see if it was the case with vanilla lighting, which it wasn't as you can see in the screenshots below.

Crash Report

If applicable, please include a link to a complete crash report. You can use Gist (https://gist.github.com) to create this link. These reports can be found in .minecraft/crash-reports.

N/a

Bug Context

If applicable, add some context to the bug. If a crash occurred while you were in-game, what happened before the crash? For example, "I fell from a high place and before the hurt sound could play the game crashed."

The first screenshot displays vanilla lighting at night time with lighting coming from a lantern. The second one is is the same except with old lighting rendering enabled. The third screenshot shows the F3 menu while standing on a block that should have a block lighting of 4, but it looks the exact same as light levels 3 to 0. The fourth screenshot is just the bug at display from a farther distance with the brightness set to 100%. In every other screenshot it was set to 0%.

Screenshots

[Thombias]

I forgot to mention something else in here: This lighting bug appears only when sky lighting meets block lighting. If light is being cast from a light source for example underground where there's no sky lighting at all, it will look perfectly fine.

A similar bug is present during rain or thunderstorm while outside. From here, it looks like the torch is only casting light in a 2 block radius during rain and a 3 block radius during thunderstorm, even though in vanilla it should go at least a bit farther than that. I know vanilla lighting has different tinting and such, but when it comes to the actual brightness, the transition between light levels just abruptly stops very early and i don't know why. I do have Rubidium and Starlight installed. Starlight rewrites the whole light rendering to be more performant and fixes some issues across the board, but what i've shown here through the screenshots and such still was present with a Forge+NostalgicTweaks-only client.

(First screenshot is during rain with old lighting enabled, second one during rain with vanilla lighting, third & fourth screenshots are for thunderstorm)

[Adrenix]

Thank you for the screenshots and extra detail, much appreciated!

[Adrenix]

After further research, it seems the way the mod renders light now is how old light rendering looked before Minecraft Beta 1.8.

I'll make a new old light color tweak so users can disable the old light rendering but keep the old colors. The mod is getting close to the anticipated 2.0 release, so I will add in the new tweak for 2.0 builds. 👍

[Thombias]

Thanks a ton for the consideration! Though i genuinely do not remember Beta Minecraft having lighting transitions this harsh like in the screenshots i've provided here so far. So i actually went ahead and fired up Beta 1.7.3, waited until night time to see if it really looked like in my screenshots above, and then compared it back again from my modded setup. (Because i cannot tell for how many blocks the torch is casting its light) and this is what i've stumbled upon:




At first i couldn't quite put my finger on it until i had both the beta screenshots and the ones from your mod opened at the same time. And then it dawned on me. The issue isn't the range of the lighting being casted from light sources (in fact the torch casts a light for the exact same distance in both your mod and true beta 1.7.3), it is the brightness itself that's a little bit inaccurate here. Hope this helps improving your mod and keep up the great work! :)

[Adrenix]

This issue should be fixed in the most recent beta release.