Adrenix/Nostalgic-Tweaks

Incompatibility with reeses sodium options

Closed this issue · 9 comments

This mod adds extra settings options to video settings with sodium. Including features for settings that optifine has. It crashes on startup.

My game crashes on startup though it seems to be due to a Mixin Error: https://pastebin.com/qbHDq3Qu
Disabling your mod fixes the crash.

Thanks for sharing that crash report. It seems to be an issue with the old cloud height tweak. If you disable it via the config file the game should start.

Other users with similar crash reports have noted that removing sodium extras mod fixes a lot of other issues too. Sodium extras lets you edit the cloud height and fog which Nostalgic Tweaks already does.

You still need to fix this issue, telling players to disable something in the mod config is not intuitive and will make people not want to use the mod. A good thing to keep in mind is that 90% of the Minecraft player base does not know how to report bugs to their respective mod authors and are not willing to do so (mostly because of general laziness and/or lack of knowledge as said before).

I would just remove the old cloud height config option if it's causing a startup crash since, like you said before, Sodium Extras fills in that role very neatly.

Also, what setting in the json file do I need to change in order to fix this myself?

I never said I wasn't going to fix this issue... I offered a temporary solution to the problem until I can find time to work on the mod again. I work on this mod for free so development happens whenever I have the time to do so.

The easiest temporary solution is removing Sodium Extras. If you want to keep that mod then setting "oldCloudHeight": true to "oldCloudHeight": false might let the game start. If it doesn't then you will have to wait until I can develop a permanent fix.

I never said I wasn't going to fix this issue... I offered a temporary solution to the problem until I can find time to work on the mod again. I work on this mod for free so development happens whenever I have the time to do so.

The easiest temporary solution is removing Sodium Extras. If you want to keep that mod then setting "oldCloudHeight": true to "oldCloudHeight": false might let the game start. If it doesn't then you will have to wait until I can develop a permanent fix.

Sorry if I sounded hostile back there, that message was poorly composed due to me acting like a pessimist for no reason. It could be because of something else but I still cannot figure out why I was in a such a shitty mood.

Also, changing that config option in the JSON file does not stop the crash from happening. Although, disabling Sodium Extras seems to be what was causing the issue.

Don't worry about it, it's fine.

I am still learning the do's and don'ts with mixins so the fix may be simple (or complex). I'm sorry to hear that the config option didn't work. The next update I do will be focused on patching up compatibility issues. 👍

Hey, just an update. Like lonelysauce said, it is actually sodium extra which causes the issues (sodium extra depends on reeses sodium options). Disabling anything in the config doesnt make a difference. Thanks!

This issue is now fixed in v1.0.3.