location search is buggy upon undo
yochannah opened this issue · 8 comments
see screenshot - pressing undo will return to the previous search, but will leave the coordinates for location present in the search bar. Leaving them there implies the filter is still active (it isn't) and when you try to reset them, we get a little console error.
UI:
Console:
To reproduce: try this search in location: 3:2578486..2580016
@yochannah Is there a way to avoid im-table of showing the Undo message?
not officially. I'd still like to show the message, as it is informative. We could be sneaky and do something like
.im-empty-apology .alert .btn {display:none}to hide that button though 😁
is there any scenario in which the button should be used, btw, or is it better to force the user to use the filters on the left hand side?
@yochannah Yes, I just wanted to hide the button, since we are already handling the reset and removal of filters by ourselves, and that button is breaking the regular flow of the browser, since I can't control its behaviour. So perfect just hiding the button.
@yochannah I dont think the button should be required, since we already handle the filters by ourselves. 😄
Sounds good!! 👍
@yochannah @rachellyne Fixed with b195e47 (http://im-browser-prototype.herokuapp.com/), if its ok, feel free to close this issue 👍
looks good