Change scanning to use the camera's location and not the players in-world location
ASchneider-GitHub opened this issue · 2 comments
Describe the bug
When Monster Spawner
and Mossy Cobblestone
are enabled as shown below for the purpose of dungeon-hunting, the renderer doesn't appear to work consistently. I'm unsure of it it's because I'm in free-cam mode, but turning the xray function on and off while outside free-cam mode doesn't seem to fix it. My settings are below:
but when the renderer is enabled, it appears to only render select blocks:
Despite the distance setting being 15
, and the mossy cobblestone and spawner being enabled, you can see in the screenshot above that it's not being detected. The other instances of yellow renders are the correctly detected blocks.
Unsure of whether this is a fault in the mod, or my understanding of how the Distance
setting is supposed to work.
To Reproduce
Steps to reproduce the behavior:
Unknown how to reproduce it, because I'm not sure what's causing it. Settings for the mod are in the screenshot above though.
Expected behavior
All mossy cobblestone and spawner blocks within the 15 chunk radius should be detected by the mod. The missed blocks in the screenshot are offset from the player by x=60,y=144,z=125
Minecraft Enviorment
- Minecraft Version:
1.20.1
- XRay Mod Version:
advanced-xray-fabric-1.20.1-1.6.0-build.17.jar
- Mod Pack & Version if applicable:
N/A
- Forge Version if applicable
N/A
- Fabric Version:
fabric-api-0.85.0+1.20.1.jar
Additional context
Edit: As I was writing this, I realized the mod had missed another dungeon with mossy cobblestone and a spawner in it directly above the instance in the first screenshot. You can actually see the originally-missed dungeon in the bottom center background.
It uses the real world position of the player, not the camera
The instances of missed blocks above are within the 15 chunk radius. Mentioned is that the offset of the missed blocks from the player's location is x=60,y=144,z=125
, which is roughly x=4 chunks, z=8 chunks. Is the Distance setting a radius, or a diameter of the whole search area?