Presets props are sent to the API, which are not sent by the official UI.
Closed this issue · 5 comments
While debugging my requests against the API and comparing it with the ones from the WebUI, I noticed something weird.
My first thought was that the presets files are outdated, but indeed they do match the ones I can export from the Web UI.
The following properties in red are part of the preset files, but the Web UI does not send them to the API, while this library does.
I don't know, if this affects the generation (because I seem to have other issues atm) or if the API ignores them, but I think we should make sure our requests matches them from the official Web UI.
These values are default values, they do not affect the generation because :
- Their value put them in a "disabled" state (does nothing)
- Their behavior should be disabled when they are not part of the preset by not being in the 'order' parameter.
One thing that could be done is filtering out parameters that are not part of enabled sampling methods (not in 'order'), which is what the website does.
If you're using Anime_v3 model, different default settings between the website and this repo are:
- the website default uses k_euler sampler with scale 5
- this repo uses k_euler_ancestral sampler with scale 11
This can affect the result, remember to set the sampler if needed.
All 3 models use different default configuration, the current default is more a holdover from v1 than anything. It feels awkward to change these default at each new version, considering any model can be used with an ImagePreset; rather I want people to customize their configuration (even more so there is no official settings preset in image gen).
One thing I could do, however, is make a factory function that would build the ImagePreset from the defaults of the chosen model, and remove the defaults.
"Explicit is better than implicit."
- Zen of Python
This issue is stale because it has been open for 30 days with no activity. It will be closed if no activity happens within the next 7 days.
This issue was closed because it has been stale for 7 days with no activity. Reopen it if relevant or open a new issue, further discussion on closed issues might not be seen.