Any plan to upgrade electron to support darwin-arm64?
njusang opened this issue · 2 comments
njusang commented
Dear maintainers,
With the current version of electron
I find it hard to install electron on my MacBook Pro (13-inch, M1, 2020), with the following output
➜ CloudClass-Desktop git:(release/apaas/1.1.2) ✗ node ./node_modules/electron/install.js
(node:43866) UnhandledPromiseRejectionWarning: HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v7.1.14/electron-v7.1.14-darwin-arm64.zip
at EventEmitter.<anonymous> (/Users/syx/Code/CloudClass-Desktop/node_modules/@electron/get/node_modules/got/source/as-stream.js:35:24)
at EventEmitter.emit (events.js:375:28)
at module.exports (/Users/syx/Code/CloudClass-Desktop/node_modules/@electron/get/node_modules/got/source/get-response.js:22:10)
at ClientRequest.handleResponse (/Users/syx/Code/CloudClass-Desktop/node_modules/@electron/get/node_modules/got/source/request-as-event-emitter.js:155:5)
at Object.onceWrapper (events.js:482:26)
at ClientRequest.emit (events.js:387:35)
at ClientRequest.origin.emit (/Users/syx/Code/CloudClass-Desktop/node_modules/@electron/get/node_modules/@szmarczak/http-timer/source/index.js:37:11)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:647:27)
at HTTPParser.parserOnHeadersComplete (_http_common.js:126:17)
at TLSSocket.socketOnData (_http_client.js:515:22)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:43866) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:43866) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Is there a plan to support the Apple M1 macbook?
Thanks and best regards,
Jennifer
plutoless commented
hi @njusang you may change to electron 11+, i believe M1 is supported since that release
njusang commented
Thank you @plutoless
Not a problem anymore.
With release/apaas/2.1.1, the version was bumped to 12.
CloudClass-Desktop/packages/agora-classroom-sdk/package.json
Lines 163 to 165 in f285b9b