AhoyISki/Firedecor

HiDPI border rounding artifacts on window corners

Electrostasy opened this issue · 4 comments

I'm using a 3840x2160 display with 1.5 scaling. There are visible artifacts seen around the border radius:
image
It's kind of a rectangle.

From my testing, it appears they only don't appear on 1.0 scaling:
image
The fact that everything is a bit blurry is inherent with fractional scaling I suppose. Would it be feasible to mitigate this "rectangle" effect? I've only ever worked with cairo using the Python bindings, but from my understanding, it could be possible it is introducing its own upscaling artifacts.

It might be the case that the corner needs to be rendered at a higher resolution and then reduced in size in order to fit properly. I'll work on it, but I'm currently dealing with other problems in the plugin.

I started testing this issue in my machine and discovered 2 things:

  1. It is not exclusive to HiDPI monitors, since it also happens on my regular 1080p monitor if I change the scale;
  2. The default Decoration plugin for wayfire also has the same issue, but just on borders, since there are no corners.
    Just some things to point out.

From my testing, it appears they only don't appear on 1.0 scaling:

Any whole scaling, actually.

It seems like this is an issue with wayfire itself, and the way it handles scaling of layout areas, see WayfireWM/wayfire#1454.

I see, thank you for looking into it. I haven't used very many decoration plugins with as many options as yours so I suppose I just never noticed before.