AhsanAyaz/ngx-device-detector

Angular 15 compatibility

3JTek opened this issue · 6 comments

3JTek commented

The library dependencies are Angular 14's which is not compatible with Angular 15's.

This create an issue when installing dependencies on an application using Angular 15:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: cerberus@0.13.3
npm ERR! Found: webpack@5.75.0
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"^5.68.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^4.29.5" from lit-scss-loader@1.1.1
npm ERR! node_modules/lit-scss-loader
npm ERR!   lit-scss-loader@"^1.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Solution:

Upgrade dependencies to:

 "peerDependencies": {
        "@angular/common": "^15.0.0",
        "@angular/core": "^15.0.0"
      }
ivineettiwari commented

@jawaidgadiwala Can you please update on this?
The merge for the angular 15 updates was done but the Jobs failed.

sandeep18051989 commented

I am also using device detector package in one of my angular 14 project, yesterday I was trying to upgrade it to 15, all packages got upgraded easily except this device detector. Can you please release its update that can support Angular 15 latest ?

p3root commented

would be nice if we see this finished soon @jawaidgadiwala .

thanks

  • 👍2
lvetskov commented

Yeah, I started having this error since yesterday and it really annoying.

AhsanAyaz commented

I'm looking at it today :) This shouldn't have been merged without a release plan.
Will hopefully have a release by end of today.

AhsanAyaz commented

@3JTek @p3root @p3root @sandeep18051989 @lvetskov @ivineettiwari We've released version 5.0.1. That should fix the problems.
Feel free to reopen the issue if you find any problems. Everything looks good on the Demo site

  • 👍3
  • ❤️1