AidanDelaney/StarshipFontana

SFApp::OnExecute() missing return statement

Closed this issue · 2 comments

AlmasB commented

https://github.com/AidanDelaney/StarshipFontana/blob/master/src/SFApp.cpp#L57

Was it supposed to return some error code if errors occurred within the main loop?

AidanDelaney commented

Yes, it should return SF_ERROR_NONE (at least) which comes from SFCommon.h.

yanneves commented

PR #6 addresses this, but may not be an acceptable fix.