Idea: Allow channels to be muted on both chips
Closed this issue · 5 comments
The MB2 is great, but it lacks the option to mute channels on the YM/SN chips.
This is an interesting feature to "deconstruct" tracks and listen to each instrument if we want to.
I know this is trivial in terms of needs to be done to the chip writes, but i'm not so sure about the UI.
I actually started experimenting with the source code and was able to create a sub-menu with this option.
I will be more than happy to submit a pull request once I finish some extra testing. :)
Cool!
I've recorded a quick video with the preliminary implementation. I just noticed I had a bug in the channel decoding logic of the YM2612, the channels are numbered 0,1,2 then 4,5,6 (it skips number 3).
https://www.youtube.com/watch?v=LfFcEJUGSFE
If I don't find any other weird bugs in my logic I will submit a pull request.
I think I've pulled an earlier commit because I see FW 1.22 on the display, I have to check and clone again to have FW 1.23 locally and then apply my changes again.
OK, I think the code is good enough for a pull request.
I forked the repo and pushed my changes. Let me know if you have any questions/feedback.
Merged changes. Thanks again for the contribution! I'll go ahead and close this issue for now, but feel free to comment here again or submit a new PR if you happen to have any changes you'd like to make to your routine!