Idea: Allow channels to be muted on both chips

Question

Idea: Allow channels to be muted on both chips

Closed this issue 3 years ago · 5 comments

The MB2 is great, but it lacks the option to mute channels on the YM/SN chips.
This is an interesting feature to "deconstruct" tracks and listen to each instrument if we want to.

I know this is trivial in terms of needs to be done to the chip writes, but i'm not so sure about the UI.

Answer 1 · 2021-09-13T02:39:59.000Z

I actually started experimenting with the source code and was able to create a sub-menu with this option.

I will be more than happy to submit a pull request once I finish some extra testing. :)

Answer 2 · 2021-09-13T03:11:56.000Z

Hello! That sounds like a good feature and I’d more than happy to help research it/implement your changes. I’m actually wrapping up a vacation on the other side of the world right now, so I’ll be pretty silent these next couple days. Once I get back and all settled in I’ll take a look. Feel free to submit a pull request for review.

…

On Mon, Sep 13, 2021 at 9:40 AM renedare ***@***.***> wrote: I actually started experimenting with the source code and was able to create a sub-menu with this option. I'm more than happy to submit a pull request once I finish some extra testing. :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACG7C34XLXJJD6Q7MZKXJJTUBVQAVANCNFSM5DXHCS4Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Answer 3 · 2021-09-13T16:02:58.000Z

Cool!

I've recorded a quick video with the preliminary implementation. I just noticed I had a bug in the channel decoding logic of the YM2612, the channels are numbered 0,1,2 then 4,5,6 (it skips number 3).

https://www.youtube.com/watch?v=LfFcEJUGSFE

If I don't find any other weird bugs in my logic I will submit a pull request.

I think I've pulled an earlier commit because I see FW 1.22 on the display, I have to check and clone again to have FW 1.23 locally and then apply my changes again.

Answer 4 · 2021-09-15T20:43:04.000Z

OK, I think the code is good enough for a pull request.

I forked the repo and pushed my changes. Let me know if you have any questions/feedback.

Answer 5 · 2021-09-17T21:32:19.000Z

#13

Merged changes. Thanks again for the contribution! I'll go ahead and close this issue for now, but feel free to comment here again or submit a new PR if you happen to have any changes you'd like to make to your routine!