AirenSoft/OvenMediaEngine

RTMP stream from OSEE GoStream causes OME to crash immediately

getroot opened this issue · 10 comments

Discussed in #1630

Originally posted by bchah May 31, 2024
RTMP or RTMPS streams coming to OME from the OSEE GoStream Deck causes an immediate crash:

[2024-05-30 21:35:53.933] I [SPRTMP-t1935:644] Provider | stream.cpp:51   | Unknown/(100) has been started stream
[2024-05-30 21:35:53.934] I [SPRTMP-t1935:644] RTMPProvider | rtmp_provider.cpp:194  | A RTMP client has connected from 
[2024-05-30 21:35:53.944] I [SPRTMP-t1935:644] RTMPProvider | rtmp_stream.cpp:977  | [?InvalidApp?/] ChunkSize is changed to 60000 (stream id: 0)
[2024-05-30 21:35:53.947] W [SPRTMP-t1935:644] RTMPProvider | rtmp_stream.cpp:302  | Could not obtain tcUrl from the RTMP stream: []
[2024-05-30 21:35:53.955] C [SPRTMP-t1935:644] OvenMediaEngine | signals.cpp:124  | OME v0.16.5 ((From archive)) received signal 11 (SIGSEGV), interrupt.

Has anybody else tried this new switcher out yet? Besides this issue it's quite feature-packed and priced the same as an ATEM Mini.

This is an RTMP metadata compatibility issue. We need to connect that encoder to our server and look at how it sends the metadata. @dimiden

bchah commented

Thank you guys, I am happy to assist with sending test streams, providing remote access to connected computers, etc.

@bchah I sent you the RTMP information for the test.

@bchah
For now, I have fixed the issue where OME was crashed in the eb72d65. The compatibility with OSEE GoStream is still being worked on, and an update will be provided soon.

bchah commented

Hi @dimiden, thank you for your work on this. I tried with the latest dev docker image and the crash is still occurring in the same manner, unfortunately. Please let me know if you would like to set up another test stream. Happy to help however I can!

@bchah
Oooops! I just checked that other parts might have problems too.
I'm sorry, but please double check on the latest version. e76384d

bchah commented

Sorry @dimiden, the crash is still occurring from the dev docker image that was just pushed. If you are certain you've fixed the problem, could it be a layer cache issue in your docker build?

@bchah
Oh, I am really, really sorry.
I tested with the RTMP dump packet you sent earlier and found that the same code is present elsewhere as well.
I was in a hurry yesterday and did not test it thoroughly.
I have committed it 4dbece7, and it should work.

bchah commented

@dimiden thank you, now OME is no longer crashing 👍

Now when connecting from the OSEE GoStream I get this in the logs. Interesting how it doesn't pick up even the client address.

[2024-06-12 13:28:51.111] I [SPRTMP-t1935:565] Provider | stream.cpp:51   | Unknown/(100) has been started stream
[2024-06-12 13:28:51.112] I [SPRTMP-t1935:565] RTMPProvider | rtmp_provider.cpp:194  | A RTMP client has connected from 
[2024-06-12 13:28:51.112] I [SPRTMP-t1935:565] RTMPProvider | rtmp_provider.cpp:221  | The RTMP client has disconnected: [Unknown/], remote: 

@bchah
Yes. OME is currently having compatibility issue with OSEE GoStream, so I made sure to disconnect for now.
I'm currently working on the compatibility issue, so I'll let you know when it's updated!
(I don't think it's difficult to solve, but I'm very busy right now, so it'll take a little time.)