AlanKuurstra/mousefMRIPrep

dependent_iterable is scalar object

Closed this issue · 2 comments

Based on my understanding of the code, the current design of dependent_iterable as a scalar object assumes that BIDSInputExternalSearch is only going to depend on a single iterable, but you may iterate over multiple values, e.g. iterate over subjects and masks to create masked subjects, then a BIDSInputExternalSearch for masked subjects would depend on two iterables to create the full list of masked subject on which to operate. Does the dependence need to be expands to handle multiple iterables?

@mklassen , currently dependent_iterable is a scalar and the search assumes it will only depend on a single iterable, which is just the most obvious use case.

It is unclear how much functionality to include in this framework's iteration functionality if there are plans to create a separate framework outside of the pipeline for iteration. Ie. autobids etc. It's also not immediately obvious to me that the extension would be simple.

Unless you think multiple dependency support is important, I would suggest extending the iteration framework only if it's requested

This should probably be addressed in the context of #17, which would involve more extensive changes in a version 2.