Accessors conflicts: Apple has @origin and @size inside its private internals

Question

Accessors conflicts: Apple has @origin and @size inside its private internals

stanislaw opened this issue 11 years ago · 7 comments

stanislaw commented 11 years ago

Hello,

See genericspecific/CKUITools#8

Cheers!

Answer 1 · 2013-10-04T11:28:22.000Z

Oh sh*t...
I'll fix this soon, or will merge PR ;)

Answer 2 · 2013-10-04T11:32:12.000Z

I'll fix this soon, or will merge PR ;)

This depends on a solution you will come up with. As you can see CKUIKit does it the following way:

@property CGPoint position; // (aka origin)
@property CGSize viewSize;

And mine variant is to have:

@property CGPoint viewOrigin;
@property CGSize viewSize;

Actually I don't like them both (but mine is a bit more conservative and consistent).

Let's see what will be your solution ;)

Answer 3 · 2014-03-10T07:10:28.000Z

Any news about this?

Answer 4 · 2014-03-12T16:46:58.000Z

@AlexDenisov, I suggest you to follow my way: viewOrigin and viewSize. I do not make a PR myself because I am not sure if you think it will be consistent for FrameAccessor.

Answer 5 · 2014-03-12T17:13:12.000Z

@stanislaw, if you want to send a PR - I'll merge it.
Sorry for delays, have a lot of work.

Answer 6 · 2014-03-12T17:30:44.000Z

@sSegev, we've done it.

Answer 7 · 2014-03-12T17:34:00.000Z

@stanislaw Great, Thanks.