AlexeySoshin/smali2java

Useless Project

Closed this issue · 2 comments

Elmue commented

It seems that this is a completely unfinished project that is not even processing half of the Smali code.
I see the majority of Smali code unchanged as comments only.
I also see variables (v1, v6, etc) beeing used that have never been assigned before.
Why are the braces of try and if not nested ? They are all at the begin of the line. This makes code completely unreadable.
What is the usefulness your project ?
Will you ever finish it ?
Why do you upload this project at all?

If you look at the following lines, would you say that this is human readable output ?
Would you say that this is Java code ?

/* move-exception v0 */
/* move-object/from16 v18, v3 */
/* move-object/from16 v26, v4 */
/* move-object/from16 v27, v5 */
/* move-object/from16 v25, v6 */
/* move-object v5, v7 */
/* move-object/from16 v17, v8 */
/* move-object/from16 v22, v11 */
/* move-object v8, v12 */
/* move-object v3, v13 */
/* move-object v7, v14 */
/* move-object v4, v0 */
} // .end local v4 # "file_channel":Ljava/nio/channels/FileChannel;
} // .end local v6 # "raf":Ljava/io/RandomAccessFile;
} // .end local v7 # "Appfiledir":Ljava/lang/String;
} // .end local v11 # "backupfilepath":Ljava/lang/String;
} // .end local v12 # "firstloadfilepath":Ljava/lang/String;
} // .end local v13 # "Cookiefileinzip":Ljava/lang/String;
/* .local v3, "Cookiefileinzip":Ljava/lang/String; */
/* .local v5, "Appfiledir":Ljava/lang/String; */
/* .local v8, "firstloadfilepath":Ljava/lang/String; */
/* .restart local v17 # "Appprofiledir":Ljava/io/File; */
/* .restart local v18 # "Cookiefile":Ljava/io/File; */
/* .restart local v22 # "backupfilepath":Ljava/lang/String; */
/* .restart local v25 # "raf":Ljava/io/RandomAccessFile; */
/* .restart local v26 # "file_channel":Ljava/nio/channels/FileChannel; */
/* .restart local v27 # "file_lock":Ljava/nio/channels/FileLock; */
/* goto/16 :goto_2e */
/* .line 514 */
} // .end local v17 # "Appprofiledir":Ljava/io/File;
} // .end local v18 # "Cookiefile":Ljava/io/File;
} // .end local v22 # "backupfilepath":Ljava/lang/String;
} // .end local v25 # "raf":Ljava/io/RandomAccessFile;
} // .end local v26 # "file_channel":Ljava/nio/channels/FileChannel;
} // .end local v27 # "file_lock":Ljava/nio/channels/FileLock;
/* .local v3, "Cookiefile":Ljava/io/File; */
/* .restart local v4 # "file_channel":Ljava/nio/channels/FileChannel; */
/* .local v5, "file_lock":Ljava/nio/channels/FileLock; */
/* .restart local v6 # "raf":Ljava/io/RandomAccessFile; */
/* .restart local v7 # "Appfiledir":Ljava/lang/String; */
/* .local v8, "Appprofiledir":Ljava/io/File; */
/* .restart local v11 # "backupfilepath":Ljava/lang/String; */
/* .restart local v12 # "firstloadfilepath":Ljava/lang/String; */
/* .restart local v13 # "Cookiefileinzip":Ljava/lang/String; */
/* :catch_34 */
/* move-exception v0 */
/* move-object/from16 v18, v3 */
/* move-object/from16 v26, v4 */
/* move-object/from16 v27, v5 */
/* move-object/from16 v25, v6 */
/* move-object v5, v7 */
/* move-object/from16 v17, v8 */
/* move-object/from16 v22, v11 */
/* move-object v8, v12 */
/* move-object v3, v13 */
/* move-object v7, v14 */
/* move-object v4, v0 */
} // .end local v4 # "file_channel":Ljava/nio/channels/FileChannel;
} // .end local v6 # "raf":Ljava/io/RandomAccessFile;
} // .end local v7 # "Appfiledir":Ljava/lang/String;
} // .end local v11 # "backupfilepath":Ljava/lang/String;
} // .end local v12 # "firstloadfilepath":Ljava/lang/String;
} // .end local v13 # "Cookiefileinzip":Ljava/lang/String;
/* .local v3, "Cookiefileinzip":Ljava/lang/String; */
/* .local v5, "Appfiledir":Ljava/lang/String; */
/* .local v8, "firstloadfilepath":Ljava/lang/String; */
/* .restart local v17 # "Appprofiledir":Ljava/io/File; */
/* .restart local v18 # "Cookiefile":Ljava/io/File; */
/* .restart local v22 # "backupfilepath":Ljava/lang/String; */
/* .restart local v25 # "raf":Ljava/io/RandomAccessFile; */
/* .restart local v26 # "file_channel":Ljava/nio/channels/FileChannel; */
/* .restart local v27 # "file_lock":Ljava/nio/channels/FileLock; */
/* goto/16 :goto_20 */
/* .line 519 */
} // .end local v3 # "Cookiefileinzip":Ljava/lang/String;
} // .end local v17 # "Appprofiledir":Ljava/io/File;
} // .end local v18 # "Cookiefile":Ljava/io/File;
} // .end local v22 # "backupfilepath":Ljava/lang/String;
} // .end local v25 # "raf":Ljava/io/RandomAccessFile;
} // .end local v26 # "file_channel":Ljava/nio/channels/FileChannel;
} // .end local v27 # "file_lock":Ljava/nio/channels/FileLock;
/* .restart local v4 # "file_channel":Ljava/nio/channels/FileChannel; */
/* .local v5, "file_lock":Ljava/nio/channels/FileLock; */
/* .restart local v6 # "raf":Ljava/io/RandomAccessFile; */
/* .restart local v7 # "Appfiledir":Ljava/lang/String; */
/* .local v8, "Appprofiledir":Ljava/io/File; */
/* .restart local v11 # "backupfilepath":Ljava/lang/String; */
/* .restart local v12 # "firstloadfilepath":Ljava/lang/String; */
/* .restart local v13 # "Cookiefileinzip":Ljava/lang/String; */
/* .restart local v16 # "Cookiefile":Ljava/io/File; */
/* :catchall_23 */
/* move-exception v0 */
/* move-object/from16 v26, v4 */
/* move-object/from16 v27, v5 */
/* move-object/from16 v25, v6 */
/* move-object v5, v7 */
/* move-object/from16 v17, v8 */
/* move-object/from16 v22, v11 */
/* move-object v8, v12 */
/* move-object v3, v13 */
/* move-object v7, v14 */
/* move-object v4, v0 */
/* move-object/from16 v18, v16 */

This is an opensource project. You are more than welcome to submit PRs to improve it.

Elmue commented

So you upload code which is not working and expect others to fix it ?