Alexthw46/StarbuncleMania

Fluid Sourcelink is over consuming fluids

Closed this issue · 3 comments

starbunclemania-1.19.2-1.0.9

Test setup looks like this:
image

I then add liquefied source to the tank until the sourcelink is at 100%

image

The recipe loaded in the Imbuement Chamber is a modified Abjuration Essence recipe. It requires 500 Source:

image

Our recipe for Liquefied > Source is 0.9
https://github.com/EnigmaticaModpacks/Enigmatica9/blob/a7f22b4ad40ac09de002bde516e2195e52080e39/kubejs/server_scripts/base/recipes/starbunclemania/fluid_sourcelink.js#L11

So I would expect crafting one essence to cost less than one bucket. Unfortunately, it appears to consume far more. 4 buckets, in fact.

image

Original report: EnigmaticaModpacks/Enigmatica9#783

spotted the issue, the sourcelink was checking the conversion ratio as the amount to fill, instead of mult it for the amount of fluid to consume

sent the version with the fix to curse, also the fix for the trash behavior not resetting

Awesome! Thanks!