Alfresco/acs-deployment

Missing `common.ingress.` templates in 5.2.0

dkekel opened this issue · 9 comments

Hi,

I'm trying to deploy Alfresco Helm v5.2.0, but I'm facing an issue. Every ingress chart relies on the following templates: "common.capabilities.ingress.apiVersion", "common.ingress.supportsPathType" and "common.ingress.backend".

Those templates do not exist in the v5.2.0. I don't see anything related in the documentation.

Should I include an additional chart dependency? Or were those templates simply forgotten in the commit?

Thanks

OK, it looks like this dependency is required:

  - name: common
    repository: https://charts.bitnami.com/bitnami
    version: 1.8.0

It is probably worth mentioning it in the documentation.

Hi @dkekel ,
This dependency should be fulfilled by the alfresco-search or the alfresco-sync-service subchart (or the postgresql which is itself a bitnami dep) . That's the main reason why in 5.2.0 charts alfresco-search doesn't have a condition to disable it and is considered mandatory.
Did you remove that dependency in some way? If so then yes, you need to add that dependency manually. If not... then we most likely have another issue to investigate and in that case we'd need more info from you.

Though we recognize current dependency management is not optimal and aim at improving it

Hi @alxgomz ,

Not really, I'm simply importing the main Alfresco chart without any additional changes (below is my complete Chart.yaml):

name: XXXX-helm
description: XXXX ArgoCD deployment
version: XXXX
apiVersion: v2
keywords:
  - XXXX

dependencies:
  - name: alfresco-content-services
    version: 5.2.0
    repository: https://kubernetes-charts.alfresco.com/stable

This didn't work, resulting in the error that indicated missing templates. It was fixed when I explicitly added the bitnami dependency as mentioned in my previous comment.

@dkekel is that not bringing the transitive dependencies? you should not have that error, can you create a repo that shows how to reproduce please?

Hi @dkekel ,

I've tried the following and could not reproduce the issue:

helm create test && cd test
echo -n 'dependencies:\n  - name: alfresco-content-services\n    version: 5.2.0\n    repository: https://kubernetes-charts.alfresco.com/stable' >> Chart.yaml
helm dep up
helm template ./ --set=global.tracking.sharedsecret='dummy'

That worked without error

Hi @mteodori , @alxgomz , it might be cause by Kustomize in fact. This is the full error I'm getting when there's no explicit Bitnami dependency:

rpc error: code = Unknown desc = `sh -c env > env.txt && helm template . --set availability_zone=$AVAILABILITY_ZONE -f $VALUES_FILE_PATH --name-template $RELEASE_NAME_CUSTOM --namespace $ARGOCD_APP_NAMESPACE > overlays/all.yaml && kustomize_3_8_7 build overlays > total.yaml && argocd-vault-plugin generate total.yaml -s vault-configuration` failed exit status 1: Error: template: efiles-helm/charts/alfresco-content-services/templates/ingress-share.yaml:3:24: executing "efiles-helm/charts/alfresco-content-services/templates/ingress-share.yaml" at <{{template "common.capabilities.ingress.apiVersion" .}}>: template "common.capabilities.ingress.apiVersion" not defined Use --debug flag to render out invalid YAML

Probably it does not bring properly transitive dependencies when processing the templates...

If you can provide a test case to reproduce easily we can try and have a look otherwise I would rather close this as the title hints at a problem which is not there with a standard usage of this chart

Hi @mteodori ,

We apply quite a few kustomizations on the original charts. Unfortunately I don't have enough time to play with it to understand which one exactly causes the issue.

For the time being I'll stick to the explicit dependency declaration since it works.

Thank you for your help.

HI @mteodori,
I experience the same issue in our environment and probably understand the issue.
I enabled Alfresco-search-Insight-Engine but disabled Postgresql as a container.
We have a closed network without any communication to the internet so nothing is dynamically pulled from the Internet.

In that case I have the same error being raised until I enable Postgresql.
It seems the common is not loaded in the Search chart but it is loaded in the Postgresql chart.

Regards,
Dick