Alfresco/alfresco-sdk

Redundant fileSet in SDK 4 all in one archetype-metadata.xml?

binduwavell opened this issue · 1 comments

The first fileSet appears to be redundant for <module id="${rootArtifactId}-platform-docker"

            <fileSets>
                <fileSet encoding="UTF-8" filtered="false">
                    <directory>src/main/docker/license</directory>
                    <includes>
                        <include>**</include>
                    </includes>
                </fileSet>
                <fileSet encoding="UTF-8" filtered="false">
                    <directory>src/main/docker</directory>
                    <includes>
                        <include>license/**</include>
                        <include>Dockerfile</include>
                        <include>disable-webscript-caching-context.xml</include>
                    </includes>
                    <excludes>
                        <exclude>**/*.properties</exclude>
                    </excludes>
                </fileSet>
                <fileSet encoding="UTF-8" filtered="true">
                    <directory>src/main/docker</directory>
                    <includes>
                        <include>**/*.properties</include>
                    </includes>
                    <excludes>
                        <exclude>license/**</exclude>
                        <exclude>Dockerfile</exclude>
                        <exclude>disable-webscript-caching-context.xml</exclude>
                    </excludes>
                </fileSet>
            </fileSets>

I have not performed an exhaustive analysis of this file, just ran into this while debugging something else.

ohej commented

Fixed by #537