CMake: replace the deprecated find_package(PythonInterp) with find_package(Python2/3)

Question

CMake: replace the deprecated find_package(PythonInterp) with find_package(Python2/3)

Closed this issue 6 years ago · 4 comments

Some CMake variable names will have to be changed, i.e. PYTHON2_EXECUTABLE will become Python2_EXECUTABLE, PYTHON2_LIBRARY will become Python2_LIBRARIES, etc.

Answer 1 · 2018-10-26T17:51:15.000Z

Make sure to change this in function find_python within DetectPython.cmake as well as any other place

Answer 2 · 2018-10-26T18:10:32.000Z

A lot of stuff in DetectPython.cmake seems in need of deprecation, i.e. Python3_SITEARCH and Python2_SITEARCH are found by CMake directly and don't have to be manually set using interpreter output on lines 160-189. Check out what they currently use in OpenCV, see if it's any better, and see what you can remove. Less code = better in this case.

Answer 3 · 2018-11-11T00:02:10.000Z

This is not pertinent for now -- especially considering the FindPython2 and FindPython3 only appear in CMake 3.12 and a large portion of the world is using previous versions. However, this still needs to be done for CMake 3.12 and above to ensure a smooth transition.

Answer 4 · 2018-12-19T21:00:44.000Z

This is unnecessary -- handled in DetectPython.cmake already