Possible validation bug at stringtable.cpp::111

Question

Possible validation bug at stringtable.cpp::111

stevenrutherford opened this issue 11 years ago · 1 comments

if (length > STRINGTABLE_MAX_VALUE_SIZE) 
  BOOST_THROW_EXCEPTION(stringtableValueOverflow() << (EArgT<1, uint32_t>::info(valsize)));

While length and valsize are related (byte length vs bit length?), it seems like you are comparing length against a valsize. This has a code smell to it.

Answer 1 · 2014-02-09T07:35:02.000Z

Thanks for noticing that. You're right about length and valsize, length is in byte while valsize is in bit. The exception might be a bit misleading at that point.