Cannot update selection during playback (fixed in stable branch)

[martin-ward]

With version 0.21.19 I can change the current selection during playback (which I find to be a very useful feature).

With version 0.22.04 I have to stop playback before I can change the selection.

[AlisterH]

I have reenabled it in this git branch, please try it: https://github.com/AlisterH/gwc/tree/allow_select_during_playback

I had a vague idea I disabled this to prevent a rare crash, but I didn't mention that in the commit message (the main purpose of the commit was to fix another crash when clicking in the view without a file open), so perhaps I just thought it was bizarre being able to change the selection while playing a selection (rather than playing all the audio in the view). Maybe we could add an additional check so that you can make a selection during playback only if playing all the audio in the view. It would be inconsistent, but less bizarre.

[martin-ward]

I have been using gwc for many years to edit radio recordings. To find the start or end of a programme I click around in the file: when the required position has been found I quickly drag a small selection around the current play position (while it is still playing) and then stop playing and zoom in. If select is not allowed during playback, I have to click "stop" first, then the current position dissappears when I start the selection, so it can easily be lost or missed.

The new version allows selection during playback, but stops playing (and loses the position) if the new selection starts before the current position (as it usually will!)

[AlisterH]

Ah.
Jeff reworked the audio playback in the last few weeks to address a criticism that the ledbars (vumeter things) aren't in sync with playback. I see that something in those changes has caused this.
I don't have time right now to try to investigate it further, but I've created another branch https://github.com/AlisterH/gwc/tree/allow_select_during_playback_v2, branched from the previous commit - you should find this one works well for you.
I'm thinking I should possibly apply all my recent changes (bugfixes mostly related to batch mode and gwcbatch) in this branch and release that as a new version until we can sort out this and any other issues with the new playback code.

Thanks

[martin-ward]

allow_select_during_playback_v2 works fine.

[AlisterH]

I'm thinking I should possibly apply all my recent changes (bugfixes mostly related to batch mode and gwcbatch) in this branch and release that as a new version until we can sort out this and any other issues with the new playback code.

Probably shouldn't have, but I've committed the change to allow selection during playback to master, and to tidy things up I've backported everything I'd committed after Jeff's changes to the playback code to a branch called "stable", so we don't need either of these allow_select_during_playback branches anymore.

In current master we need to resolve both your playback issue reported in #24 and the issue with being unable to select before the current position during playback.