Alloyed/loverocks

Support for Lua 5.3

john-cheesman opened this issue · 2 comments

Hi,

I'm trying to get this working with Lua 5.3. How would you feel about adding something like this to patch support for setfenv?

I realise this may not be the only issue with supporting 5.3 but it's the first thing that's come up.

Thanks

My main worry with supporting lua 5.3 is not necessarily getting loverocks to run, but to have it produce valid 5.1 rocks trees, including native modules (most people using loverocks are using it for the native module support). If you can crack that nut, I'm all ears~

I think have a doc somewhere documenting what exactly in luarocks needs to change so that the host version can be different from the target version, and if I can find it I'll be sure to post it here. The long and short of it is look at cfg.lua in the base luarocks repo.

That is, unless you deliberately want a 5.3 rocks tree, either for a custom build of love or for maybe non love uses. If that's the case I'd equally like to hear about it.

Thanks for the explanation. I'm not very experienced with Luarocks. Coming from web dev I always expect package managers to work like NPM!

For now I'm just having fun with Love but at some point I'll probably roll back to 5.1 and give this a go.

Thanks again