AltSchool/dynamic-rest

Django 3 support

neilfrndes opened this issue · 14 comments

neilfrndes commented

Is supporting Django 3 in the pipeline?

neilfrndes commented

I got dynamic rest to work with Django 3 by replacing the django.utils.six import to the six library.

I am happy to work on a PR to make dynamic rest compatible with Django 3 but I want to know from an expert is if replacing the six import is the biggest change needed. Moreover, since python 2.7 is soon approaching EOL, does it make sense to keep the six imports?

https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis

  • 👍4
amandeep-r commented

I can help make it compatible with django 3 but I also don't know if replacing the six import is the the biggest change needed

wlisesrivas commented

@amandeep-r try fixing the six import first.

  • 👍1
to-bee commented

Any updates here?

suavesav commented

@neilfrndes Please feel free to make a PR for this. We are working on deprecating py2 support, but for now we'll keep six around. Thanks!

  • 👍1
MikeBlomm commented

Any progress on this? Django 3 has been out for a while now, and Python 2 is also EOL.

@neilfrndes Did you happen to get it working for a PR?

amandeep-r commented

So I made a fork where I replaced all calls to from django.utils import six with import six and it's working for me.

Made a draft pull request, could use some help polishing up the requirements and installation files so it dosent show that warning message about needing to be a django version lower than 3.0 #307

  • 👍5
creyD commented

As #307 is merged, can this be closed as well?

  • 👍1
amandeep-r commented

Does this fix warrant a new release?

  • 👍7
joshvillbrandt commented

Would also love this to be included in a release! Thanks!

  • 👍4
ernestofgonzalez commented

I noticed there hasn't been much activity on this organisation's repos. Probably there won't be no more -- I think they closed.

In the meantime I forked and released a version that supports Django 3 under django-dynamic-rest. Feel free to make contributions there.

  • 👍2
ArnSch commented

We're alive and kicking, most of our work is in private repos right now though. Really appreciate the work on django-dynamic-rest @ernestofgonzalez

ernestofgonzalez commented

Hey @ArnSch. Thanks for the response. Cool to hear you guys are still alive.

Let me know if you'd like me help out with contributions in this repo and releases for dynamic-rest to avoid having users migrate. My email is ernesto@hunchat.com

suavesav commented

Released, thanks to @ernestofgonzalez and @chdastolfo