Ambrevar/emacs-gif-screencast

Error report from package-lint.el

Closed this issue · 4 comments

package-lint.el reports 2 warnings and 1 error.

138:62: warning: This key sequence is reserved (see Key Binding Conventions in the Emacs Lisp manual)
139:54: warning: This key sequence is reserved (see Key Binding Conventions in the Emacs Lisp manual)
143:0: error: Global minor modes must `:require' their defining file (i.e. ":require 'gif-screencast"), to support the customization variable of the same name.

I believe at least the error should be resolved.

Indeed, that just got introduced.

Regarding the warnings: I know about them but I can't think of good bindings. Suggestions are welcome.

IMO, for the key bindings, just make them open to users but a recommend setting should be described in README explicitly. I had the same issue on org-tree-slide then I assigned non-reserved keys.

Sounds reasonable.

Fixed in 9aa921e and df05e26.