Anamican/jbooktrader

The NTPClock object is called recursively when starting a Trade or ForwardTest session.

Closed this issue · 3 comments

What steps will reproduce the problem?
1. There appears to be a problem with the code to get the time from the 
timeserver. If getting the time fails, it recursively tries to execute the same 
code connecting to the time server.
2. I think to recreate this, you would need to have your firewall block the 
time server protocol, although I have not figured out the solution yet.
3.

What is the expected output? What do you see instead?
I expected the code to run the forward test or the trade operation.

What version of the product are you using? On what operating system?
Windows XP, just downloaded version 7.06


See attachment for recursive nature of the calls to get the time and the 
NTPCLock.

Original issue reported on code.google.com by shortbus...@gmail.com on 14 Jun 2010 at 9:08

Attachments:

the NTPClock class has a dependency on itself, when an error occurs, as the 
reporting functions have a dependency on the time features. 

It does not seem to be a good idea to me to have the reporting functionality 
with a dependency on making NTP calls to log an error. I think the NTP calls 
should be made outside the reporting objects and passed into the eventreport 
object on creation.

This must be a problem with my firewall. But this dependency seems like a bug.

Original comment by shortbus...@gmail.com on 14 Jun 2010 at 10:44

Thanks for reporting, I'll take a look shortly.

Original comment by eugene.k...@gmail.com on 14 Jun 2010 at 7:04

  • Changed state: Accepted
The fix will be in release 7.07.

Original comment by eugene.k...@gmail.com on 16 Jun 2010 at 4:01

  • Changed state: Fixed