AndrewKeig/express-validation

Express-validation does not work with Joi 9

Closed this issue · 4 comments

Joi 9 has new features that I would like to use for my project however express-validation requires a v8.x.x version of Joi.

Any chance of getting support for Joi 9?

Actually express-validation has joi as a peerDependency, so it's actually a "suggested" version.
You have to install Joi manually in your project.

I have tried installing joi@9-beta (that's the dist-tag for the beta) and express-validation 1.x, npm 3.x gives a WARN for peerdependency not respected, but it will let you install it.

Please note that express-validation has not been tested with joi9

I've done that and it works on NPM 3.x however I just realized that the machine this is failing on is running NPM 2.x. I'm looking at getting that upgraded to resolve the issue.

holm commented

It would be good if the restriction on Joi could be lifted a bit. While you can install Joi@9, you will not be able to shrinkwrap anymore (which we use).

Oh, I see. Never used shrinkwrap myself, so didn't know this would create
limitations.
Will merge at once, thanks for pointing this out

Il 19/ago/2016 23:20, "Christian Holm" notifications@github.com ha
scritto:

It would be good if the restriction on Joi could be lifted a bit. While
you can install Joi@9, you will not be able to shrinkwrap anymore (which
we use).


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACiLziXg-P3gt7EQFmfnZVoVYnq9IYVPks5qhh4igaJpZM4JGadZ
.