AngusJohnson/Image32

missing glyphs in text-on-path.svg

Closed this issue · 4 comments

The red text draws empty boxes.
Previous versions showed cyrillic glyphs.

The ParseNextWordExHash function in Img32.SVG.Core.pas has a bug, and the fix is to delete the following line...

Edit: I've just uploaded a revision that fixes this.

Edit2: But there's still a problem that's evident in Text2.svg (in the .\Examples/SVG/Sample SVGs 1 folder).

About the second issue, I'm not sure what the requirements are. The calls to IsSameUTF8String(), IsSameAsciiUTF8String() seem to expect s1 being lower case and s2 any letter case. One solution would be changing the case-statement to: case ch2 of 'A'..'Z': ch2 := UTF8Char(Ord(ch2) xor $20); If both characters can have any letter case, more is needed.
Edit: As solved already:)

The comments in IsSameUTFString and IsSameAsciiUTF8String say "toggle upper/lower", but the code I wrote only toggled the upper characters to lower. Thanks for fixing this and all the other bugs that I introduced.

And thanks for all your hard work too Andreas. I've added a brief acknowledgement of your contribution in the documentation. I hope that's ok.