Suggestion: use libjass for ass rendering
Closed this issue · 9 comments
Why?
^ What he said
We've had discussions about using other JS sub converters in IRC - And the final decision has always been a no. Fairly certain libjass (or something else with a similar name) also showed difficulties rendering more complex karaoke effects.
This is not something we plan to do in the near future unless you believe there is a very, very good reason to do so
This has been left open for over a month now with no information provided.
Closing for lack of input, we need an actual reason to perform such a change
Hmm, I could have sworn I left a comment in this thread ages ago explaining why. Well, because libjass has a much more complete and performant ASS implementation, and implementing ASS is a large enough problem that it'd probably be more worthwhile to use an established implementation than to waste time reinventing this particular wheel.
We've tested libjass before. (Or at least I believe it was, dunno, probably been a year by now) While more performant, it introduced more bugs in the displayed subtitles than ours did. Anime karaoke subs are quite weird and bad at following specs. Some even intentionally exploit non-standard tricks that work in certain players, libjass pretty much couldn't handle any of those weird situations we threw at it.
Reinventing the wheel is a valid point, but it's not my call to make. @Yay295 has been the maintainer of the .ass -> svg/css converter for a while now. If he wishes to save time by switching to libjass I will not stop him.
Another thing to consider is participating in libjass development, so that there's one really good ASS renderer instead of two okay renderers.
Possibly. Though at this time, that' would be a step back for our use due the the specific featureset we need.
But this decision is not mine to make. It's not like we're a company, time isn't money as long as someone actually wants to do it.
There are actually three I know of now. https://github.com/Dador/JavascriptSubtitlesOctopus
Some reasons our current renderer works fine:
- It can handle every file we currently have.
- It doesn't need to be compiled/transpiled.
- It's only 50KB compared to libjass' 400KB and JavascriptSubtitlesOctopus's 2MB.
Closing this issue now. libjass is dead, and we actually now support everything everything it did and more. The points in my last comment also still stand, though our subtitle code has doubled in size since then.