AniDevTwitter/animeopenings

Handle 0*0 PlayResX/PlayResY in ass files

Closed this issue · 2 comments

Hello :)

In our video database, we have various resolutions... well, a lot of them actually. On all of our mp4/h264 videos there are about 40 different heights.

As a result, most of our ass files for karaoke do not have a PlayResX/PlayResY metadata, mainly because we're still in the process of replacing low-quality videos by h264, HD versions whenever we can (on about 5800 videos, this takes some time)

We use mpv to display karaoke videos in our app (http://mugen.karaokes.moe/en) and it works just fine with PlayResX/PlayResY at 0. However, on AnimeOpenings, such ASS files make the subs appear really small.

Would there be a way to either handle 0*0 resolutions so text appears bigger? Or have it as something configurable, even, please?

That'd really be neat :)

This should fix it. 6b25d74

We were already handling missing and 0 values, just not correctly.

I confirm it fixes the issue \o/