Tags not supported
Closed this issue · 7 comments
Tags appear in interface but aren't supported.
How to reproduce:
Select anime with tags, go to personal, tags is empty.
or
Select anime, go to personal, add tags, return, reselect same anime, tags is empty.
Which website are you using?
I will look into this issue.
I experiment this issue on MAL.
On Oct 10, 2016 12:08, "ratan12" notifications@github.com wrote:
Which website are you using?
I will look into this issue.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#492 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFkZCsFmcz4GIOzoIL6_Ey2Hx9jSo_SBks5qyg6ygaJpZM4KSXUW
.
I can reproduce it but the funny thing is that I do not see any update command in the log.
It looks like the app does not call the write task.
It looks like after the dirty rewrite the Personal tags was never added as dirty field.
We use a dirty field to determine if we should update a record if the user will press back.
It was never added thus never updated and saved.
Commit 034d57a fixed it.
Thanks for reporting!
Thanks a lot for fixing this!
I'm not sure that updating the tag when
modifying is the only problem tho. As I said, tags aren't showing even if they are added through the official website.
I detail it better:
How to reproduce:
Add personal tags to an anime with MyAnimeList website. Go to Atarashii on your phone. Select the same anime, go to personal, tags is empty.
Did I just seriously fixed an unknown bug by misunderstanding.
I just tried what you said using the official website and the app is not syncing it.
Update:
Apparently there was a code missing in the API models.
Why? I have honestly no idea but it has been fixed now so you can update and read the personal tags in the next minor version.
Commit f8f6fb3
Ah ah I found two separate bugs in row without even noticing!
Great job, thanks!
On Oct 15, 2016 16:33, "ratan12" notifications@github.com wrote:
Did I just seriously fixed an unknown bug by misunderstanding.
I just tried what you said using the official website and the app is not
syncing it.Update:
Apparently there was a code missing in the API models.
Why? I have honestly no idea but it has been fixed now so you can update
and read the personal tags in the next minor version.
Commit f8f6fb3
f8f6fb3—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#492 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFkZCoknAQQU8mJCEQsywpB9ZnyKjLMdks5q0OQggaJpZM4KSXUW
.