AnonymouX47/term-image

iTerm2 image protocol support

AnonymouX47 opened this issue · 13 comments

AnonymouX47 commented

A branch off #23

Tested terminal emulators:

  • iTerm2
  • WezTerm
  • Konsole >= 22.04.0
    • Currently doesn't support native animations but the normal method used across all styles works excellently.

All functionalities work properly across all terminals except stated otherwise.

Progress:

  • Sizing
  • Rendering
    • Line-by-line
    • Whole image
  • Transparency
  • Formatting
  • Animation
  • CLI Integration
  • TUI Integration
  • Tests

Specific protocol features already or to be in use:

  • Native animation
AnonymouX47 commented

@paw-lu @leo-arch

Just tests left to go... You can check #50 for progress.

  • 👍1
leo-arch commented

Hi @AnonymouX47. No Mac here.

AnonymouX47 commented

Tested on iTerm2... the only quirk was that drawing line-by-line is extremely slow due to the terminal's performance.

I'll mention it in the docs and set the whole render method to be used instead, wherever possible.

AnonymouX47 commented

Hi @AnonymouX47. No Mac here.

Yeah, about that... I just got my hands on one over here 😃
Thanks.

leo-arch commented

That was fast!

  • 😄1
AnonymouX47 commented

I'm releasing the next version (0.4.0) on the 14th of this month.
I should've completed the support for the graphics protocols but wherever it gets, I'll release it.

  • 👍1
  • 🎉1
AnonymouX47 commented

Finally!

By the way, I found out that mintty (on Windows) implements this protocol... I've only given it a short try so far with no luck yet but as soon as I work it out, I'll add mintty to the supported terminal emulators.
There's also hterm but I'm less interested based on what I've read about it's implementation... the terminal emulator is not as widely used after all.

AnonymouX47 commented

@Sam-Cleveland
Please, will you be able to help test on iTerm2?
You would have to clone and install from the main branch.

Sam-Cleveland commented

make test-iterm2 failed. Here's the output
log.txt

AnonymouX47 commented

Thanks.

I noticed your local main branch is not up to date... i just merged #55 a few hours ago.

Also, among the output you sent is this:

.../tests/test_iterm2.py:15: PytestUnknownMarkWarning: Unknown pytest.mark.order - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html @pytest.mark.order("first")

This shows that the pytest-order package is not installed.
Run:

make requires

OR

pip install --upgrade -r requirements.txt

Thanks :)

AnonymouX47 commented

Also, I should note that the tests are independent of the terminal emulator they're running on.

What I actually meant by "test" earlier is more about using it to displaying images to see if it works as expected. :)

AnonymouX47 commented

What I actually meant by "test" earlier is more about using it to displaying images to see if it works as expected. :)

@Sam-Cleveland, anything so far? :)

AnonymouX47 commented

Finally 🥲, v0.4.0 is up!

Sorry, I couldn't meet up with the date I originally mentioned due to some difficulties.
I actually considered releasing it as it was then but I think the wait was worth it, with the amount of things that happened between then and now 😃.

Anyways... I've learnt to avoid dates henceforth 🌚😆, as so many things compete for my time.