Anorov/PySocks

Installing PySocks on Windows + Python 2.7 no longer installs win-inet-pton

pquentin opened this issue · 0 comments

pquentin commented

#89 modified setup.py to install win-inet-pton on Windows + Python 2.7. This worked fine for source releases. However, 1.7.0 and 1.7.1 were released as wheels, and no longer include this addition, which breaks the urllib3 tests.

I guess there are three options:

  • remove mentions of win-inet-pton in setup.py and explain in the README that it should be installed separately
  • provide a Python 2.7 + Windows wheel for each release
  • Stop supporting Python 2.7 with python_requires in setup.py

Thanks!