MLP rib build -> ablation pipeline is broken.

Question

MLP rib build -> ablation pipeline is broken.

nix-apollo opened this issue a year ago · 3 comments

This change is breaking for run_mlp_ablations, as run_mlp_ablations expects to find mlp config information at results["model_config"]["model"]. Instead mlp rib build now stores only the mlp config info, omitting mlp training config, etc.

Answer 1 · 2023-12-15T12:13:15.000Z

Probable change is to go back to storing training information, etc in rib results. But I'm unsure what's best for consistency with modular mlp and eventually combining ablation scripts

Answer 2 · 2023-12-18T16:37:16.000Z

Yeah I think I'd like to have all train information stored in the results. I'm going to work on this now and make a PR to main, since I'd like to have this in the refactor.

Answer 3 · 2023-12-18T18:19:09.000Z

OK I decided against this to keep things consistent with lms. Otherwise it's a bit messier.