Destroy building hotkey (X) skips confirmation after a set state
Dr-Doofus opened this issue · 2 comments
Hello, I have found several issues involving the destroy building hotkey provided in the planet interface.
After the player receives an amount of cash ranging between 1k and 10k (I can not find the exact point which it does), it entirely skips the building deletion dialog, thus usually accidentally removing a building likely valuable to me.
After some additional research involving the issue, it stops confirming it even with zero cash.
I would also like to note that if you press the destroy building hotkey while the window is open, the console returns this error:
ERROR: Signal 'confirmed' is already connected to given method 'destroy_building_confirm' in that object.
at: (core/object.cpp:1474)
That behavior is intentional actually, if the lifetime money you earned is greater than the money cost of the building you're destroying divided by a certain number, it stops giving confirmation, since the game considers you can build it back easily if you destroy by accident. But I'm open to change, should it always give a confirmation?
As for that signal error, yeah I've seen that error since a long time ago but never got around to fixing it since it doesn't freeze the game
Ah, makes sense. Making an "always show destroy confirmation" setting would be fantastic.