AppliedAcousticsChalmers/ambisonics-for-insta360-pro

Fix git submodules

HaHeho opened this issue · 1 comments

HaHeho commented

The git submodules are not correctly recognized in the repository.

  1. I believe

    ambisonics-for-insta360-pro/.gitmodules

    Line 3 in c04068a

    url = https://github.com/thomasdeppisch/eMagLS

    should be url = https://github.com/thomasdeppisch/eMagLS.git instead.

  2. The ambisonics encoding toolbox is missing, so something like the following should be added.

[submodule "signal_processing/ambisonic-encoding"]
	path = signal_processing/ambisonic-encoding
	url = https://github.com/AppliedAcousticsChalmers/ambisonic-encoding.git

In both cases, the submodules should be updated/added via the respective git commands, not by manually modifying the .gitmodules file directly. After a successful update, the submodules should also appear on GitHub.

JensAhrens commented

Thanks for the heads up!

This is solved by a452eae.