Sometimes screen not switch to single mode when you close it to single screen on duo 1

Question

Sometimes screen not switch to single mode when you close it to single screen on duo 1

sir86 opened this issue 3 months ago · 14 comments

sir86 commented 3 months ago

Acknowledgements

I have chosen an appropriate title.
All requested information has been provided properly.
This is not a feature request.
This issue is not a duplicate of an existing issue.
The issue is solely related to this GSI.
This issue occurs with the latest available build.
I am not running a custom vendor on my device.
This issue is not kernel related.
This issue is not related to Magisk/KernelSU/APatch.

Info

Device:
GSI version:
Vendor version:

Expected Behavior

Screen should always switch to single mode when close it to single screen.

Current Behavior

Sometimes screen not switch to single mode when you close it to single screen on duo 1 and you see only half on the screen.

Possible Solution

No response

Steps to Reproduce

Logs

No response

Additional context

No response

Answer 1 · 2024-09-27T21:00:54.000Z

The description is not clear to me. How to reproduce this issue?

Answer 2 · 2024-09-27T23:03:34.000Z

when you open phone fully to look like tablet and use both screens for some time then back to single screen by moving one screen one the back to make it look like a phone, sometimes screen not switch to phone mode and u see half of tablet mode on the screen. its not happening very often. Maybe 3 times per day. Then you have to close phone fully and reopen and its fine again. i have this issue since i first installed this rom. I first installed [v2024.07.25 then i using OTA and its happening from time to time since then. I think its a posture issue. Very good work btw

Answer 3 · 2024-09-29T13:40:56.000Z

This sometimes happens on Duo 2 as well, but it's not clear to me exactly why it does that, a little hard to reproduce consistently.

Answer 4 · 2024-09-29T17:20:39.000Z

It could be an issue with the hall sensor of the particular units then.

It should be visible in the log,

run the following command and change the fold to reproduce the issue,

adb logcat | grep 'POSTURE PROCESSOR'

If it is not producing the output for the hinge angle or the hinge angle value is not changing, the sensor has an issue.

Answer 5 · 2024-10-01T13:41:27.000Z

log.txt

Here is a log with that issue. I notice if I quickly open from closed to one screen, it tends to work better, but opening to two screens first, then single screen tends to trigger the issue.

Answer 6 · 2024-10-01T13:51:30.000Z

The posture seems to update with the change in hinge rapidly, so I do not think this is a sensor issue.

Answer 7 · 2024-10-01T13:55:17.000Z

10-01 23:54:08.425  3379  3379 D POSTURE PROCESSOR: Processing posture Closed : R0
10-01 23:54:08.433  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:08.925  3379  3379 D POSTURE PROCESSOR: hall value: 1
10-01 23:54:08.929  3379  3379 D POSTURE PROCESSOR: Hall wake up. Register sensors
10-01 23:54:09.085  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 0
10-01 23:54:09.218  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 157
10-01 23:54:09.283  3379  3379 D POSTURE PROCESSOR: Got posture FlatDualP : R0
10-01 23:54:09.284  3379  3379 D POSTURE PROCESSOR: Updating posture because previous or new are closed
10-01 23:54:09.284  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.284  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.303  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:09.317  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 197
10-01 23:54:09.383  3379  3379 D POSTURE PROCESSOR: Got posture FlatDualL : R90
10-01 23:54:09.383  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.383  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.390  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:09.396  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 233
10-01 23:54:09.567  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 259
10-01 23:54:09.613  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 266
10-01 23:54:09.782  3379  3379 D POSTURE PROCESSOR: Got posture RampRight : R90
10-01 23:54:09.783  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.783  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.790  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:09.793  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 306
10-01 23:54:09.793  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 322
10-01 23:54:09.983  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 360
10-01 23:54:09.983  3379  3379 D POSTURE PROCESSOR: Got posture FlipLRight : R90
10-01 23:54:09.985  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.985  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.991  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:16.387  3379  3379 D POSTURE PROCESSOR: Got posture FlipLRight : R270
10-01 23:54:16.389  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:16.389  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:16.399  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!

Particularly here, it seems to get stuck on one posture even though the hinge has changed angle

Answer 8 · 2024-10-01T14:02:59.000Z

Seems like the PostureSensorListener is reporting the right posture, but the subsequent function processPosture seems to revert back to the previous posture?

Answer 9 · 2024-10-01T18:04:13.000Z

10-01 23:54:08.425  3379  3379 D POSTURE PROCESSOR: Processing posture Closed : R0
10-01 23:54:08.433  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:08.925  3379  3379 D POSTURE PROCESSOR: hall value: 1
10-01 23:54:08.929  3379  3379 D POSTURE PROCESSOR: Hall wake up. Register sensors
10-01 23:54:09.085  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 0
10-01 23:54:09.218  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 157
10-01 23:54:09.283  3379  3379 D POSTURE PROCESSOR: Got posture FlatDualP : R0
10-01 23:54:09.284  3379  3379 D POSTURE PROCESSOR: Updating posture because previous or new are closed
10-01 23:54:09.284  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.284  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.303  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:09.317  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 197
10-01 23:54:09.383  3379  3379 D POSTURE PROCESSOR: Got posture FlatDualL : R90
10-01 23:54:09.383  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.383  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.390  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:09.396  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 233
10-01 23:54:09.567  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 259
10-01 23:54:09.613  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 266
10-01 23:54:09.782  3379  3379 D POSTURE PROCESSOR: Got posture RampRight : R90
10-01 23:54:09.783  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.783  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.790  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:09.793  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 306
10-01 23:54:09.793  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 322
10-01 23:54:09.983  3379  3379 D POSTURE PROCESSOR: Setting hinge angle 360
10-01 23:54:09.983  3379  3379 D POSTURE PROCESSOR: Got posture FlipLRight : R90
10-01 23:54:09.985  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:09.985  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:09.991  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!
10-01 23:54:16.387  3379  3379 D POSTURE PROCESSOR: Got posture FlipLRight : R270
10-01 23:54:16.389  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:16.389  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0
10-01 23:54:16.399  3379  3379 D POSTURE PROCESSOR: Setting display composition 2 new!

Particularly here, it seems to get stuck on one posture even though the hinge has changed angle

Mmmm interesting

Answer 10 · 2024-10-01T18:12:34.000Z

It looks like the composition is not updated and stuck at 2 in this particular case.

composition 2 is for the tablet mode, it should be either 0 or 1 in the phone mode.

Answer 11 · 2024-10-01T18:21:59.000Z

I wonder how this happened,

10-01 23:54:16.387  3379  3379 D POSTURE PROCESSOR: Got posture FlipLRight : R270
10-01 23:54:16.389  3379  3379 D POSTURE PROCESSOR: Loaded X: 1344 Y: 1892 HINGE: 66 OFFSET: 672
10-01 23:54:16.389  3379  3379 D POSTURE PROCESSOR: Processing posture FlatDualP : R0

It registers FlipLRight but processes FlatDualP.

Note: I think I found the issue, drafting a new release on this.

Answer 12 · 2024-10-01T22:47:53.000Z

Could you guys please check the latest release and try to reproduce the issue?

Answer 13 · 2024-10-02T01:53:27.000Z

I can't seem to replicate the issue anymore on the new release, seems to be fixed. If I encounter the bug I'll post an update here.

Answer 14 · 2024-10-02T02:07:00.000Z

Great, thanks