ArchiveTeam/wpull

FTP login information in URLs is lost

JustAnotherArchivist opened this issue · 0 comments

It appears that wpull loses the login information in FTP URLs somewhere along the way.

$ wpull --verbose --warc-file test ftp://macgarden:publicdl@repo1.macintoshgarden.org/Garden/games/HP2.toast_.zip
ERROR AuthenticationError: Login error: ("Failed action Login password: 530 'Login incorrect.'", 530)
INFO Exiting with status 6.

--debug does not provide any useful information, but the WARC shows that the username and password get stripped from the URL and wpull attempts to log in anonymously instead:

WARC/1.0
WARC-Type: metadata
Content-Type: text/x-ftp-control-conversation
WARC-Date: 2021-04-09T00:54:39Z
WARC-Record-ID: <urn:uuid:189ae18f-95c4-4d36-873f-3631862486ee>
WARC-Target-URI: ftp://repo1.macintoshgarden.org/Garden/games/
WARC-IP-Address: 158.174.73.78
WARC-Block-Digest: sha1:YNZSDUHEJFPM2AZB4K7MQDBE5U226O4Y
Content-Length: 255
WARC-Warcinfo-ID: <urn:uuid:58dfd30e-428e-43ae-a5fc-e9af2a0d9e05>

* Opening control connection to 158.174.73.78:21
< 220 ProFTPD 1.3.4a Server (ProFTPD) [::ffff:192.168.1.10]
> USER anonymous
< 331 Password required for anonymous
> PASS -wpull@
< 530 Login incorrect.
* Closed control connection to 158.174.73.78:21

wpull 2.0.3, Python 3.6.10, Debian buster