Localized steps (Keyword) are not fully supported

Question

Localized steps (Keyword) are not fully supported

Closed this issue 13 years ago · 9 comments

In lot of place, localized keyword are not supported and "Given", "When", ... are hardcoded.
Check syntax hightlighting and keyword detectors in the xxxScanner classes

Answer 1 · 2012-02-08T09:12:40.000Z

Just so you know, I am working on this. However it is a little slow going and might take a while longer, because I have not made up my mind about the presentation of the language configuration and on how to keep it low impact on the existing codebase.

Answer 2 · 2012-02-08T10:15:44.000Z

that's great! thanks!

here are some links of hard coded values

LineParser.java one should take care of the method stepSentenceIndex if the step keyword is not a one word only
AbstractStoryPartBasedScanner.java where i attempted to handle comment on token emitted
Potentially all scanners in the o.t.j.e.editors.story.scanner package
And management in the completion see StepContentAssistProcessor.java#L75, StepContentAssistProcessor.java#L112

Hope this helps a bit

Not part of the localized keyword, but mostly related on i18n see Issue 36 for the templates that use english keywords only

In the meanwhile, i'll add the story locale in the preference page, if you've not done it yet.

Answer 3 · 2012-02-08T10:39:15.000Z

No, I have not changed the preferences in a meaningful way yet, just rammed in a simple text field to enter a string that I use with Locale.get... A little more style (and an implementation as a project level setting) would certainly be in order.

Answer 4 · 2012-02-10T16:51:32.000Z

I am working on the feature right now. As there have been no commits from you (none that I could see at least :)), I am also adding the language to the editor preferences as a popup.
I will attempt to fill it from the available JBehave localized keyword files.

Answer 5 · 2012-02-10T23:49:49.000Z

I won't have a chance to work on this for the next two weeks. You are welcome to take a look at what i have done so far. Currently there is a problem when the language is changed - editors don't recognize the steps anymore. Maybe you want to take a look at that.

Answer 6 · 2012-02-11T08:31:18.000Z

Sure, i'll have a look, does it correspond to LocalizedKeywords branch?

Answer 7 · 2012-02-12T21:01:38.000Z

Yes, exactly.

Answer 8 · 2012-02-12T21:05:20.000Z

I'm currently looking at it, refactoring many methods to make them rely on JBehaveProject instead of being static since the story locale can be project specific and not global. I'll commit the current state once at least it compiles.

Furthermore, i've moved the locale selection into a dedicated preference page, so that it can easily be available for project properties too.

Answer 9 · 2012-05-08T12:54:50.000Z

Should be available for 1.0.7