Consider making block confirmations configurable

Question

Consider making block confirmations configurable

jakerockland opened this issue 2 years ago · 3 comments

Should we consider moving https://github.com/ArtBlocks/MintingKit/blob/main/Sources/MintingKit/MintingKit.swift#L9 to instead live as a var that is mutable within the MintingKit struct to allow this to be client configurable?

Answer 1 · 2022-09-23T20:58:30.000Z

I'm taking this a step further and making it so the block confirmations are pulled from the contract automatically a la this part of the admin panel:

Answer 2 · 2022-09-23T20:59:28.000Z

So different contracts on different networks/L2/whatever else can be configured differently, and those varying configurations will work on the same machine. So one machine that mints three different projects from three different contracts on three different networks will use the right number of block confirmations for each one accordingly.

Answer 3 · 2022-09-23T21:27:51.000Z

So different contracts on different networks/L2/whatever else can be configured differently, and those varying configurations will work on the same machine. So one machine that mints three different projects from three different contracts on three different networks will use the right number of block confirmations for each one accordingly.

Great point 👑 appreciate the direction in https://github.com/ArtBlocks/minting-machine/pull/42 / #11 , much better. 🐐