ArthurHoaro/web-thumbnailer

error type given

Closed this issue · 2 comments

agentcobra commented

I use v2.0.3 in shaarli and get this error when refreshing thumbnails:

[Thu Nov 05 18:34:21.146472 2020] [php7:notice] [pid 29009] [client 172.17.20.1:38716] TypeError: Argument 1 passed to WebThumbnailer\\Utils\\ImageUtils::isImageString() must be of the type string, bool given, called in /var/www/shaarli.agentcobra.net/vendor/arthurhoaro/web-thumbnailer/src/WebThumbnailer/Finder/DefaultFinder.php on line 59, referer: https://shaarli.agentcobra.net/admin/thumbnails

it referer to :

web-thumbnailer/src/WebThumbnailer/Finder/DefaultFinder.php

Line 59 in 39bfd4f

if (empty($thumbnail) && ImageUtils::isImageString($content)) {

function definition is here :

web-thumbnailer/src/WebThumbnailer/Utils/ImageUtils.php

Line 177 in 39bfd4f

public static function isImageString(string $content): bool

I use:

  • Linux
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 10 (buster)
Release:        10
Codename:       buster
  • Apache2
Server version: Apache/2.4.38 (Debian)
Server built:   2020-08-25T20:08:29
  • PHP
PHP 7.3.19-1~deb10u1 (cli) (built: Jul  5 2020 06:46:45) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.19, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.19-1~deb10u1, Copyright (c) 1999-2018, by Zend Technologies
ArthurHoaro commented

Sorry for the very late answer. Thanks for the very clear report 👍

This can happen if the remote content could not be retrieved. I'll send a PR to fix this and add proper checks before calling this method.