Astoundify/wc-simple-registration

Shortcode Name

Closed this issue · 8 comments

spencerfinnell commented

Looks good! Will give it a test soon.

The Shortcode should be [woocommerce_register] though to remain consistent though.

adampickering commented

I tested it on the demo works fine, how does this effect ReCaptcha support?

Can I use ReCaptcha on this registration form? woocommerce/woocommerce#1136

@JeroenSormani @spencerfinnell

adampickering commented

Actions

then the processing action later on which you can throw errors in https://github.com/woothemes/woocommerce/blob/master/includes/class-wc-form-handler.php#L892
spencerfinnell commented

If all WC did was add the action for outputting it then I think it's up to the captcha plugin to handle validation, etc. This plugin definitely shouldn't do any validating. Just output the form.

JeroenSormani commented

I've used the exact woocommerce template, with all the hooks.

Checked, and the registration_form hook, and its newer version woocommerce_registration_hook are in there too 👍

JeroenSormani commented

@spencerfinnell I 50/50 agree with you on the shortcode name. For consistancy we should change it, but chances are, maybe small, that [woocommerce_registration] will be used by Woo itself.

I suggest to use [woocommerce_simple_registration] otherwise.

spencerfinnell commented

Good point. Lets go with [woocommerce_simple_registration]