Squished buttons with tiny icons in Storage list
Closed this issue · 8 comments
Description
The buttons at the bottom of the Storage item have a squished shape and the icons in them are scaled down, making them extremely hard to see. This may be a result of the increased length of the Storage item list since the addition of the Top processes section.
Steps to Reproduce
- Install and enable the extension.
- Click the Storage item on the top bar.
- The buttons at the bottom of the list are squished and the icons are tiny.
Screenshots
Environment
- Astra Monitor Version: 9 (EGOv13)
- GNOME Version: 45.3
- Operating System and Version: Fedora 39 Workstation
I'm not able to reproduce that. Do you still have this bug?
Yes, even with the TypeScript testing version (which I currently use). I only see this issue on the Storage item list, which occupies the whole vertical length of my screen. The other items are not as long, so that's why I suspect it's an issue with the list's length.
Do you have any item list as long? If not, maybe you can reproduce the bug by artificially creating a long item list (for example by adding more processes in the Top processes section).
Of course I'll be happy to share more information if you tell me what I can do to get that!
Ok, now I reproduced the bug. We don't actually have a way to properly display many items with a scrolling bar for example. For now I can add a setting like for the networks to manually hide some storage selecting them or with a regex.
Understandable. Perhaps a check box list presenting all the drives/partitions to the user would be nice for this. Then the user could select all the drives/partitions that they would like to monitor. However, the issue of the squished buttons could still occur if the user selects many drives/partitions.
As a more proper solution, and since all drives/partitions have the same height, would it be possible for a calculation to be made and adapt the list to fit the user's monitor? For example by hiding the last n entries if the list's length exceeds the monitor's effective height? A message could also be added informing the user that some entries are hidden.
Done:
The additional solution you proposed will be integrated into menu customization in a future version, which is currently absent. However, I have a wide range of customizations listed for what is shown in the menus and even in what order that will eventually be implemented in the future.
I just tested the latest changes and ignoring partitions works properly! However, now the bars showing how full the devices are appear empty (see screenshot). Since these changes are not yet in a released version, I'm not sure if I should report this as a new bug, thus I'm mentioning it here.
Wow, very good catch. This is actually a bug introduced by the fix for #50. Gonna fix that right now!
Just tested. All is well!