Changing theme has no effect
Closed this issue · 8 comments
Description
Changing the theme of the extension has no effect. No matter the setting, the theme remains dark. I would expect the theme to change depending on the setting.
Steps to Reproduce
- Install and enable the extension.
- Open the extension's preferences.
- Go to General tab, open Theme and change Shell Theme Style to Light.
- The theme remains dark.
Environment
- Astra Monitor Version: 9 (EGOv13)
- GNOME Version: 45.3
- Operating System and Version: Fedora 39 Workstation
- Other Relevant System Information: Xorg session
I think that option here is not very clear in its purpose. It's supposed to be used to improve the graphical look in case you have a light theme or have enabled the light shell (see screenshot below). It was necessary because there is no way through gnome to know if the theme or shell is light. Perhaps a subtitle specifying this should be added, if you have suggestions on how to explicate it more clearly they are welcome.
It is not clear indeed. So if a light shell is enabled, the extension's theme can be set to either dark or light, but if a dark shell theme is enabled the option does nothing? Do you have control over the extension's theme, so that it can actually change the theme to light when a dark shell theme is used?
It indeed "does something" even if the theme is dark, in theory you should see the colors of the graph edges and backgrounds change slightly.
If you cannot make the option actually change the theme, the subtitle you may add should be something like the following:
Due to GNOME Shell restrictions, setting the theme to Light only has effect when using a Light Shell theme.
Actually I can change the colors of various things when you select 'light' anyway, but actually only the things that improve the visibility are changed. I just noticed while testing, by the way, that some things can still be improved for the light shell, I am going to make some tweaks on it right now.
As a description of this option I think it is more appropriate to put something that explains what the option does, like:
Fixed the option description and now light theme readability is a lot improved. Thank you!
Just checked. The changes are subtle but are there. I can mostly observe a difference in the gray values of the axes tick labels. If these are the only changes, could you perhaps select a value that would look acceptable both in light and dark themes (i.e. a value between the one you use for the dark and light theme) so that the theme selection option would be removed?
With the latest changes it's already much better with light themes. But with this setting you can enhance readability even further. Keep in mind that a light top bar is not supported by GNOME, light theme still have a dark top bar, and you actually have to install/enable an extension to force that.