Indentation inconsistencies in preferences panel

[lepa22]

Description

I really like the new appearance of the items in the Preferences panel of the extension. The greyed submenus and the indentation make things much clearer, however I have noticed some inconsistencies which I mention below.

1. In the General tab, the Monitor Ordering section is not a submenu, so the items there should not be indented:

   

   ^{Click for larger image.}

2. In the Processors tab, the Main GPU submenu is not indented:

   

   ^{Click for larger image.}

3. In the Storage tab, the Usage Bar, Usage Percentage, Usage Value, and Free Value items of the Main Disk item are essentially headers (level 1 submenu items) which contain submenu items (level 2 submenu items). While the indentation here is not actually wrong, it is not clear at first glance what these level 1 submenu items are and the whole submenu looks busy. Perhaps making the level 1 submenu items bold or clickable items with submenus could make this more consistent and easy to understand.

   

   ^{Click for larger image.}

4. In the Network tab, the checked network item on the Ignored Network Interfaces is not correctly indented:

   

   ^{Click for larger image.}

   In other cases with items with icons, they are indented further to the right, aligned with the rest of the items. Example:

   

   ^{Click for larger image.}

Environment

• Astra Monitor Version: 12 (EGOv19)
• GNOME Version: 45.3
• Operating System and Version: Fedora 39 Workstation

[ljuzig]

I fixed 1 and 2. Number 3 is intended that way as they are subcategories that groups the settings below them. Can't replicate 4 and 5 as you can see from this screen:

[lepa22]

Thanks! I can see that the items in my screenshots are more indented than in your screenshot. Maybe the items with the checkmarks have the correct indentation and the Regex item is more indented. I will check the version with the other fixes and report back. Perhaps the issue of screenshot 4 is accidentally fixed by another fix.

[lepa22]

I just checked with the latest fixes. All seems to be working as intended except for the checkmark alignment issue in screenshot 4. And I still observe a generally larger indentation than what's shown in your screenshot...

[ljuzig]

I couldn't replicate it, it could be due to a gnome version difference between us or theme margins, for now being just a minor graphical issue I would wait and see if it gets reported by anyone else or if either it gets fixed for you or it breaks for me.